-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove the dependency with k8s.io/kubernetes #5
chore: remove the dependency with k8s.io/kubernetes #5
Conversation
Signed-off-by: STRRL <[email protected]>
Signed-off-by: STRRL <[email protected]>
fff1682
to
9c6a02d
Compare
Signed-off-by: STRRL <[email protected]>
I found other issues when I remove the
It relates to changes in the interface. |
What do you think about it? @divanodestiny
|
Just keep |
got that. |
Signed-off-by: STRRL <[email protected]>
8328e59
to
ebde5a9
Compare
Updated! PTAL! @divanodestiny PS: I am very pleased to help if you meet some issue when bump the version of kubernetes deps. We (Chaos Mesh Contributors) also make a script for upgrade |
Another thing needs to be mentioned: when I tried to execute
That's a historical issue with kubernetes client-go: kubernetes/client-go#741 (comment) I am not sure why you did not face this issue. Maybe the (internal) go module proxy server that you used cached an old version for And that's the reason why I replace the |
@STRRL hi~ would you mind updating this PR to trigger the workflows, which were set recently. |
OK! I would have a try later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All checks have passed 🎉🎉🎉
Signed-off-by: STRRL [email protected]
What type of PR is this?
enhancements
What this PR does / why we need it:
k8s.io/kubernetes
replace
statement ingo.mod
:github.com/googleapis/gnostic => github.com/googleapis/gnostic v0.3.1
Which issue(s) this PR fixes:
#4
Special notes for your reviewer:
No other notes.