Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kudo init --dry-run -o yaml has some serialization issues #811

Closed
realmbgl opened this issue Sep 12, 2019 · 6 comments · Fixed by #813
Closed

kudo init --dry-run -o yaml has some serialization issues #811

realmbgl opened this issue Sep 12, 2019 · 6 comments · Fixed by #813
Assignees
Milestone

Comments

@realmbgl
Copy link

kudo init --dry-run -o yaml has some serialization issues.

What happened:
Three things I encountered

helm templating not happy with {{ .Params.COUNT }} in comment, best remove

                      file for example, if `name: COUNT` then using the variable in
                      a spec like:  spec:   replicas:  {{ .Params.COUNT }}'

1st character lower case serviceAccount, should be ServiceAccount

apiVersion: v1
kind: serviceAccount
metadata:
  creationTimestamp: null
  labels:
    app: kudo-manager
  name: kudo-manager
  namespace: kudo-system

1st character lower case namespace, should be Namespace

kind: namespace
metadata:
  creationTimestamp: null
  labels:
    app: kudo-manager
    controller-tools.k8s.io: "1.0"
  name: kudo-system
spec: {}
status: {}

What you expected to happen:
see before

How to reproduce it (as minimally and precisely as possible):
run kubectl kudo init --dry-run -o yaml

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version):
  • Kudo version (use kubectl kudo version): 0.6.0
  • Operator:
  • operatorVersion:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@alenkacz alenkacz added this to the 0.7.0 milestone Sep 12, 2019
@kensipe kensipe self-assigned this Sep 12, 2019
@kensipe
Copy link
Member

kensipe commented Sep 12, 2019

I love you man!

@kensipe
Copy link
Member

kensipe commented Sep 12, 2019

@realmbgl I don't understand this comment...

helm templating not happy with {{ .Params.COUNT }} in comment, best remove

                  file for example, if `name: COUNT` then using the variable in
                  a spec like:  spec:   replicas:  {{ .Params.COUNT }}'

@kensipe
Copy link
Member

kensipe commented Sep 12, 2019

ah.. the output of the CRD YAML has this as part of the name description... hmmm

@kensipe
Copy link
Member

kensipe commented Sep 12, 2019

could you help me understand how you are using this with helm?

@realmbgl
Copy link
Author

did a simple helm smoke test using the following commands

kubectl kudo init --dry-run -o yaml > kudo/templates/kudo.yaml

helm install -n kudo ./kudo

with the 3 things patched the install works

@kensipe
Copy link
Member

kensipe commented Sep 12, 2019

you ask and you shall receive!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants