Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Init YAML Generation #813

Merged
merged 2 commits into from
Sep 12, 2019
Merged

Bug Fix: Init YAML Generation #813

merged 2 commits into from
Sep 12, 2019

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented Sep 12, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixes bugs reported with init yaml generation

Which issue(s) this PR fixes:
Fixes #811

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@kudo-ci
Copy link

kudo-ci commented Sep 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gerred, kensipe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kensipe kensipe merged commit ba79375 into master Sep 12, 2019
@kudo-ci kudo-ci deleted the ken/init-bugs branch September 12, 2019 17:38
kensipe added a commit that referenced this pull request Sep 12, 2019
* fix serialization bug and test to confirm correct format
* removing template tags from CRD property description
kensipe added a commit that referenced this pull request Sep 13, 2019
* fix serialization bug and test to confirm correct format
* removing template tags from CRD property description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kudo init --dry-run -o yaml has some serialization issues
3 participants