-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-17: Pipe task implementation #1105
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
3332621
KEP-0017: Pipe task implementation
zen-dog d58e063
Added comments and TODOs
zen-dog 7b6d5f3
Fixed a deadlock when executing a pod command when downloading a file
zen-dog 8848320
Added tests for validating pipe task and improved pipe artifact naming
zen-dog 61dd838
Improved pipe artifact naming function
zen-dog 3811c1a
Instance controller now watches Pod events
zen-dog afb47ad
Check pipe file size before downloading it
zen-dog a921f6c
Ran go mod tidy
zen-dog fe78dd7
Added `{{ .Pipes. }} ` config object to template rendering
zen-dog d8589a9
Fix test/integration/upgrade-command
zen-dog f8e76c9
Updated the pipe specification to take a pod instead of a container
zen-dog 04c5870
Making linter happy
zen-dog 67b9a1e
Added more unit tests
zen-dog ef7ce24
Minor comment improvement
zen-dog e83fc64
First round of review feedback
zen-dog 82be1a2
Removed `io.Pipe` when executing pod commands
zen-dog c1087ec
Moved `pod_exec.go` into a separate package
zen-dog a6bf10e
Making linter happy
zen-dog 6e38698
Additional test for pipe-pod validation
zen-dog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like pipe keys are generated to guarantee uniques based on phase and step... but then are flatten in the template... is that true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand the question but:
{{.Pipes.Mycertificate}}
in line 56 above