-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify description spelling in cmd and pkg/apis. #1172
Conversation
@@ -77,12 +78,12 @@ spec: | |||
type: object | |||
type: array | |||
templates: | |||
description: List of go templates YAML files that define the application | |||
operator instance | |||
description: Yaml captures a templated yaml list of elements that define |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love most of these changes... except this one. This desc makes no sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, second this, what about: Templates is a list of references to YAML templates located in the templates folder and later referenced from tasks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM minus that one comment
@@ -77,12 +78,12 @@ spec: | |||
type: object | |||
type: array | |||
templates: | |||
description: List of go templates YAML files that define the application | |||
operator instance | |||
description: Yaml captures a templated yaml list of elements that define |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, second this, what about: Templates is a list of references to YAML templates located in the templates folder and later referenced from tasks.
This in preparation of moving to generating CRDs from the structs, in order to minimize the diff.
4d1aa8d
to
ab675c1
Compare
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noice!
Signed-off-by: Andreas Neumann <[email protected]>
This was missed in #1172 Signed-off-by: Andreas Neumann <[email protected]>
What this PR does / why we need it:
This in preparation of moving to generating CRDs from the structs, in
order to minimize the diff.
Baby step towards #862