Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional Code Linters #1304

Merged
merged 7 commits into from
Jan 27, 2020
Merged

Additional Code Linters #1304

merged 7 commits into from
Jan 27, 2020

Commits on Jan 23, 2020

  1. bumping golangci-lint to 1.23.1 

    Signed-off-by: Ken Sipe <[email protected]>
    @kensipe
    kensipe committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    fd0f744 View commit details
    Browse the repository at this point in the history

  2. interfacer linting 

    Signed-off-by: Ken Sipe <[email protected]>
    @kensipe
    kensipe committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    ca5f82e View commit details
    Browse the repository at this point in the history

  3. adding nakedret lint 

    Signed-off-by: Ken Sipe <[email protected]>
    @kensipe
    kensipe committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    6adde3a View commit details
    Browse the repository at this point in the history

  4. adding gocyclo linting 

    Signed-off-by: Ken Sipe <[email protected]>
    @kensipe
    kensipe committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    d3e6336 View commit details
    Browse the repository at this point in the history

  5. adding dupl with threshold that aligns with controller-runtime 

    Signed-off-by: Ken Sipe <[email protected]>
    @kensipe
    kensipe committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    e60d6a9 View commit details
    Browse the repository at this point in the history

  6. added goconst to linting 

    Signed-off-by: Ken Sipe <[email protected]>
    @kensipe
    kensipe committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    01ed3b9 View commit details
    Browse the repository at this point in the history

  7. adding lll as a linter with a line length limit of 250 

    Signed-off-by: Ken Sipe <[email protected]>
    @kensipe
    kensipe committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    209d60d View commit details
    Browse the repository at this point in the history