-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make lint work without a $GOPATH. #1374
Conversation
Also document the need for $GOBIN to be in developer's $PATH. Signed-off-by: Marcin Owsiany <[email protected]>
This assumes that golang-lint is in the $PATH, which is isn't always. IntelliJ (not sure about GoLand) doesn't set that, and I didn't see any option to set it. |
FWIW
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
It does work in the terminal, it doesn't work (for me) in the pre-commit-hook when committing from inside GoLand/IntelliJ. Still, I have to fix this on my side, i guess. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed my paths, so now this works for me as well.
Also document the need for $GOBIN to be in developer's $PATH. Signed-off-by: Marcin Owsiany <[email protected]> Signed-off-by: Thomas Runyon <[email protected]>
What this PR does / why we need it:
Make lint work without a $GOPATH.
Also document the need for $GOBIN to be in developer's $PATH.
Fixes #1373
Signed-off-by: Marcin Owsiany [email protected]