Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override the pull policy of the controller in 'kudo init' #1507

Merged
merged 4 commits into from
May 13, 2020

Conversation

nfnt
Copy link
Member

@nfnt nfnt commented May 12, 2020

What this PR does / why we need it:
This makes it easier to deploy KUDO in test environments where a KUDO image is available in the cluster but not in any repository.

This makes it easier to deploy KUDO in test environments where a KUDO image is available in the cluster but not in any repository.

Signed-off-by: Jan Schlicht <[email protected]>
@nfnt nfnt self-assigned this May 12, 2020
@nfnt nfnt requested a review from ANeumann82 May 12, 2020 07:21
Copy link
Member

@ANeumann82 ANeumann82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, i've had to add that in my init --upgrade branch as well, but better to have it here in a separate PR.

I would prefer a more distinctive name, but that's not a blocker for me.

The missing validation for the pullPolicy is though ;)

pkg/kudoctl/cmd/init.go Outdated Show resolved Hide resolved
pkg/kudoctl/cmd/init.go Outdated Show resolved Hide resolved
Signed-off-by: Jan Schlicht <[email protected]>

Co-authored-by: Andreas Neumann <[email protected]>
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we want to add flags to control individual fields of the output YAML even if it gets rid of the sed in tests 🤔 But it certainly needs more validation.

@nfnt nfnt requested a review from ANeumann82 May 12, 2020 09:56
@ANeumann82
Copy link
Member

I'm not sure if we want to add flags to control individual fields of the output YAML even if it gets rid of the sed in tests 🤔 But it certainly needs more validation.

We actually need this. For these tests it works with the sed, but only because we "export" the yaml before installing it. It would actually be better to use the real kudo init for installation, and in that case we can't use sed. (For the kudo init --upgrade the sed variant isn't even possible)

hack/run-e2e-tests.sh Outdated Show resolved Hide resolved
pkg/kudoctl/cmd/init.go Outdated Show resolved Hide resolved
Signed-off-by: Jan Schlicht <[email protected]>

Co-authored-by: Andreas Neumann <[email protected]>
@nfnt nfnt merged commit 27aa546 into master May 13, 2020
@nfnt nfnt deleted the nfnt/init-pull-policy branch May 13, 2020 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants