Better logging for the apply task #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which includes the GVK of the object in question to speed up debugging when applying fails. Signed-off-by: Aleksey Dukhovniy <[email protected]>
zen-dog
requested review from
alenkacz,
gerred,
kensipe and
nfnt
as code owners
alenkacz
reviewed
Aug 26, 2020
| @@ -118,7 +118,7 @@ func applyResources(rr []runtime.Object, ctx Context) ([]runtime.Object, error) | |||
| switch { | |||
| case apierrors.IsNotFound(err): // create resource if it doesn't exist | |||
| if err := addLastAppliedConfigAnnotation(r); err != nil { | |||
| return nil, fmt.Errorf("failed to add last applied config annotation to %s/%s: %w", key.Namespace, key.Name, err) | |||
| return nil, fmt.Errorf("failed to add last applied config annotation to a %s %s: %w", r.GetObjectKind().GroupVersionKind(), key, err) | |||
There was a problem hiding this comment.
how does GroupVersionKind() look as a string?
There was a problem hiding this comment.
There was a problem hiding this comment.
@gerred you're making me look lazy! :DD thanks!
nfnt
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which includes the GVK of the object in question to speed up the debugging when applying fails.
Signed-off-by: Aleksey Dukhovniy [email protected]