dedupe warning messages for deprecated API warnings #1712
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took some research to get here... many things to liggitt as well!
Fixes: #1711
Inspiration for fix from
kubectl
https://github.com/kubernetes/kubernetes/blob/release-1.19/pkg/kubectl/cmd/cmd.go#L433Details https://kubernetes.io/blog/2020/09/03/warnings/
This solution will continue to print a Warning message for each interaction that involves a deprecated API for each deprecated API but that's it... any repeated use of that API will not print.
Output for a simple
kudo init --dry-run
after the fix:Also hard to see on GH but the word
Warning:
is colored yellow as well here (which it is not below)Output for a simple
kudo init --dry-run
prior to fix:Signed-off-by: Ken Sipe [email protected]