Move warning options to 'GetKubeClientForConfig' #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfnt
requested review from
alenkacz,
gerred,
kensipe and
zen-dog
as code owners
alenkacz
approved these changes
Oct 15, 2020
ANeumann82
approved these changes
Oct 15, 2020
kensipe
approved these changes
Oct 15, 2020
As this function is used by more functions to create Kubernetes clients, more KUDO subcommands will benefit from reduced CRD deprecation warnings when running on Kubernetes >=1.19. Signed-off-by: Jan Schlicht <[email protected]>
nfnt
force-pushed
the
nfnt/dedup-warning-handler
branch
from
f8bc09b
to
fb28846
Compare
kensipe
pushed a commit
that referenced
this pull request
Nov 16, 2020
As this function is used by more functions to create Kubernetes clients, more KUDO subcommands will benefit from reduced CRD deprecation warnings when running on Kubernetes >=1.19. Signed-off-by: Jan Schlicht <[email protected]>
kensipe
pushed a commit
that referenced
this pull request
Nov 16, 2020
As this function is used by more functions to create Kubernetes clients, more KUDO subcommands will benefit from reduced CRD deprecation warnings when running on Kubernetes >=1.19. Signed-off-by: Jan Schlicht <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As this function is used by more functions to create Kubernetes clients, more KUDO subcommands will benefit from reduced CRD deprecation warnings when running on Kubernetes >=1.19.
Before:
After: