Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing left behind scaffold todos and fixing misspelling #212

Merged
merged 5 commits into from
May 3, 2019

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented May 3, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

  • removing left behind scaffold todos
  • fixing misspelling
  • added error handling where it was missing

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link
Member

@runyontr runyontr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@runyontr
Copy link
Member

runyontr commented May 3, 2019

Just have to fix the formatting of the changes so CircleCI will approve it.

@kensipe kensipe merged commit 2adee02 into master May 3, 2019
@alenkacz alenkacz deleted the ken/scaffold-cleanup branch May 30, 2019 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants