-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make deploy to print out install yaml files #282
Conversation
This is great. lgtm! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we consider the changes to the Makefile as external API changes?
I am just concerned that we might break some slides/demos which are not under our control.
As of right now, I don't believe it matters too much but we should fix that at some point.
I don't consider Makefile changes as external API changes. Maybe today, but only as "developer as the external user". This should be geared to development process. Not that I'm hugely a fan of Makefiles, would prefer some other job running system but that's what we have with Go unless we were to use https://github.com/magefile/mage or something (which I am not in favor of at this time). We've talked about |
@gerred I agree that it shouldn't be, but looking at our slide decks and demos currently it is. That is the reason why I would just keep an eye out for that. |
Good point. @mattj-io this affects you as well. We'll have this all documented in the v0.2.0 release notes...in fact, I'm going to make a label so that this isn't forgotten. |
What type of PR is this?
/kind enhancement
/kind infrastructure
What this PR does / why we need it:
Fixes #
Which issue(s) this PR fixes:
Fixes #222
It is just first step, but it should be enough to consider that issue fixed. The follow up will be #280 where we'll introduce helm integration as well as kudoctl command to print out the yaml
To prove that it works, this is from my machine
Special notes for your reviewer:
Does this PR introduce a user-facing change?: