-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break down methods in plan and instance controller #296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mea culpa! too many tabs |
takirala
force-pushed
the
tga/add-engine-package
branch
from
June 12, 2019 09:49
8358e83
to
6ca11d2
Compare
takirala
force-pushed
the
tga/add-engine-package
branch
from
June 12, 2019 10:07
6ca11d2
to
ac68428
Compare
takirala
changed the title
Initial draft to move code to a new engine package
Break down methods in plan and instance controller
Jun 20, 2019
@takirala where does this stand? |
Replaced by #563 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Breakdown the instance controller and plan controller in to smaller parts to make the codebase more readable/reusable. Here is what I have done:
Which issue(s) this PR fixes:
Partially addresses #229
Special notes for your reviewer:
Does this PR introduce a user-facing change?: