Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break down methods in plan and instance controller #296

Closed
wants to merge 8 commits into from

Conversation

takirala
Copy link
Member

@takirala takirala commented Jun 5, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Breakdown the instance controller and plan controller in to smaller parts to make the codebase more readable/reusable. Here is what I have done:

  • Breakdown methods in plan and instance controller.
  • Organise members in controller files by methods (most of these are for implementing an interface) and then followed by function (only some of them are pure functions currently)
  • I initially planned on moving these functions to engine package but to decrease scope (and to avoid dealing with merge conflicts) i am pushing this for review after moving only a sample method to engine package.

Which issue(s) this PR fixes:

Partially addresses #229

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@fabianbaier
Copy link
Member

@fabianbaier fabianbaier closed this Jun 5, 2019
@fabianbaier fabianbaier deleted the tga/add-engine-package branch June 5, 2019 17:09
@fabianbaier fabianbaier restored the tga/add-engine-package branch June 5, 2019 20:55
@fabianbaier
Copy link
Member

mea culpa! too many tabs

@takirala takirala changed the title Initial draft to move code to a new engine package Break down methods in plan and instance controller Jun 20, 2019
@takirala takirala marked this pull request as ready for review June 20, 2019 07:25
@kensipe
Copy link
Member

kensipe commented Jul 8, 2019

@takirala where does this stand?

@kensipe
Copy link
Member

kensipe commented Jul 11, 2019

Replaced by #563

@kensipe kensipe closed this Jul 11, 2019
@gerred gerred deleted the tga/add-engine-package branch October 19, 2019 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants