Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the CI run again after git-credentials removal #319

Merged
merged 3 commits into from
Jun 8, 2019
Merged

Make the CI run again after git-credentials removal #319

merged 3 commits into from
Jun 8, 2019

Conversation

alenkacz
Copy link
Contributor

@alenkacz alenkacz commented Jun 8, 2019

All CI runs now look like this:

Step 3/10 : COPY test/.git-credentials .git-credentials
COPY failed: stat /var/lib/docker/tmp/docker-builder611541570/test/.git-credentials: no such file or directory
Error when building test docker image, cannot run tests.
Tests finished successfully! ヽ(•‿•)ノ

@alenkacz alenkacz requested a review from gerred as a code owner June 8, 2019 17:26
fabianbaier
fabianbaier approved these changes Jun 8, 2019
View reviewed changes
Copy link
Member

@fabianbaier fabianbaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

test/Dockerfile
@@ -1,7 +1,6 @@
FROM kudobuilder/golang:1.12

WORKDIR $GOPATH/src/github.com/kudobuilder/kudo
COPY test/.git-credentials .git-credentials
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@runyontr runyontr merged commit dfe2810 into master Jun 8, 2019
@joerg84 joerg84 deleted the av/fix-ci branch June 9, 2019 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianbaier fabianbaier fabianbaier approved these changes

@joerg84 joerg84 joerg84 approved these changes

@kensipe kensipe Awaiting requested review from kensipe kensipe is a code owner

@runyontr runyontr Awaiting requested review from runyontr

@gerred gerred Awaiting requested review from gerred gerred is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alenkacz @fabianbaier @joerg84 @runyontr