-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove possibility to install multiple packages #479
Conversation
pkg/kudoctl/cmd/install/install.go
Outdated
kc, err := kudo.NewClient(options.Namespace, options.KubeConfigPath) | ||
if err != nil { | ||
return errors.Wrap(err, "creating kudo client") | ||
if len(args) != 1 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the main change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the direction we are going with it but found just two minor things. If we can address those I am happy with it :)
@fabianbaier thanks, great feedback :) fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@fabianbaier are you good here? I want this to land before I get to carried away with some refactor that includes install from url. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome! lgtm!
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
There are two main things in this PR:
-- I don't see much use cases for doing that vs running two
kudo install
commands-- it was not documented anywhere anyway so I think we can just remove it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: