Fix plan marked as completed when template was broken #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| restartPolicy: OnFailure | ||
| containers: | ||
| - name: bb | ||
| image: busybox:latest |
There was a problem hiding this comment.
These pods are (currently) being created against envtest so no actual containers are able to be created. If there's not a way to write this test without requiring containers to start, I'll setup a KIND environment to run our tests like we do for the operator tests (either, a separate suite or just run everything in KIND).
There was a problem hiding this comment.
Oh, this shouldn't render at all, I see :)
| labels: | ||
| controller-tools.k8s.io: "1.0" | ||
| name: invalid-v1 | ||
| namespace: default |
There was a problem hiding this comment.
Optional: drop the namespace here so it installs cleanly into the test namespace.
…r/kudo into av/fail-plan-on-missing-param
alenkacz
changed the title
gerred
requested changes
Jul 11, 2019
| planExecution.Status.State = kudov1alpha1.PhaseStateError | ||
| planExecution.Status.Phases[i].State = kudov1alpha1.PhaseStateError | ||
| // returning error = nil so that we don't retry since this is non-recoverable | ||
| return reconcile.Result{}, nil |
There was a problem hiding this comment.
Do we need to update the API object here?
There was a problem hiding this comment.
gerred
approved these changes
Jul 11, 2019
kensipe
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes behavior when error in template caused plans to be marked as complete instead of error.
Which issue(s) this PR fixes:
Fixes #499
Special notes for your reviewer:
Does this PR introduce a user-facing change?: