Extract part of logic from PlanExecutionController into function #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbarrick-mesosphere
approved these changes
Jul 22, 2019
kensipe
approved these changes
Jul 22, 2019
| } | ||
|
|
||
| // populatePlanExecutionFromActivePlanDefinition reads content of the Plan defined in operator version and populates PlanExecution with data from rendered templates | ||
| func populatePlanExecutionFromActivePlanDefinition(activePlan kudov1alpha1.Plan, planExecution *kudov1alpha1.PlanExecution, instance *kudov1alpha1.Instance, operatorVersion *kudov1alpha1.OperatorVersion, recorder record.EventRecorder) error { |
There was a problem hiding this comment.
Suggested change
| func populatePlanExecutionFromActivePlanDefinition(activePlan kudov1alpha1.Plan, planExecution *kudov1alpha1.PlanExecution, instance *kudov1alpha1.Instance, operatorVersion *kudov1alpha1.OperatorVersion, recorder record.EventRecorder) error { | |
| func populatePlanExecution(plan kudov1alpha1.Plan, pe *kudov1alpha1.PlanExecution, instance *kudov1alpha1.Instance, ov *kudov1alpha1.OperatorVersion, recorder record.EventRecorder) error { |
Do we plan to populate from another source? can the source be one of the params? this function name seems too long... also this line of code is 243 chars long...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
95% of this is just code moved around, I did not change any behavior nor did I intend to do so. My goal is to break down the current huge controller into smaller pieces with names and descriptions so that we can iteratively refactor this while adding tests.
The part I extracted in this PR is a big porting of code that was just taking plan definition from operator version and populating fields in PlanExecution before actually executing the plan.