Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping go version to 1.13 for builds and tests #791

Merged
merged 2 commits into from
Sep 11, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
path: reports/
release:
docker:
- image: kudobuilder/golang:1.12
- image: kudobuilder/golang:1.13
working_directory: /go/src/github.com/kudobuilder/kudo
steps:
- checkout
Expand All @@ -23,7 +23,7 @@ jobs:

code-formatting:
docker:
- image: kudobuilder/golang:1.12
- image: kudobuilder/golang:1.13
working_directory: /go/src/github.com/kudobuilder/kudo
steps:
- checkout
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Build the manager binary
FROM golang:1.12 as builder
FROM golang:1.13 as builder

# Setting arguments
ARG git_version_arg
Expand Down
5 changes: 4 additions & 1 deletion build/test-images.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,8 @@ docker push kudobuilder/golang:1.11
docker build --build-arg GOLANG_VERSION=1.12 -t kudobuilder/golang:1.12 .
docker push kudobuilder/golang:1.12

docker build --build-arg GOLANG_VERSION=1.13 -t kudobuilder/golang:1.13 .
docker push kudobuilder/golang:1.13

docker build --build-arg GOLANG_VERSION=latest -t kudobuilder/golang:latest .
docker push kudobuilder/golang:latest
docker push kudobuilder/golang:latest
2 changes: 1 addition & 1 deletion test/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM kudobuilder/golang:1.12
FROM kudobuilder/golang:1.13

WORKDIR $GOPATH/src/github.com/kudobuilder/kudo

Expand Down