fix(compiler): make projectReferences work with isolatedModules: true
#1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4414
💛 - Coveralls |
kulshekhar
approved these changes
Apr 16, 2020
This was referenced Apr 18, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A part of work for #766
Inspired from TypeStrong/ts-loader#817 , this PR is to make
projectReferenceswork withisolatedModules: trueCaveat
It is required to build the project first with
tsc -bto have the compiled files ready. We can look into including thistsc -bstep as improvement later.Test plan
Added e2e tests with the example repo from #766
Does this PR introduce a breaking change?
Other information
There will be similar work for
LanguageServicewhich will be in another PR