Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): allow using files provided by tsconfig #1562

Merged
merged 1 commit into from
Apr 25, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Apr 24, 2020

Summary

  • Set include received from tsconfig to an empty array to avoid loading unnecessary files to utilise incremental feature of LanguageService.
  • Revert this change in v25.5.0-alpha.0

This will fix an issue with custom typings mentioned in #1115 (comment)

Test plan

  • Added unit test and e2e test

  • Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Because of setting include to an empty array to improve performance for isolatedModules: false, any custom typing files which are intended to use with jest need to be defined in files option of tsconfig.

For example

// tsconfig.json
{
   // ...other configs
   "files": [
       "my-custom-typings.d.ts"
   ]
}

Other information

N.A.

@coveralls
Copy link

coveralls commented Apr 24, 2020

Pull Request Test Coverage Report for Build 4529

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 92.817%

Totals Coverage Status
Change from base Build 4524: 0.004%
Covered Lines: 1055
Relevant Lines: 1090

💛 - Coveralls

@ahnpnl ahnpnl force-pushed the allow-specific-files-tsconfig branch from 5d04151 to 0d9913b Compare April 24, 2020 13:02
@ahnpnl ahnpnl force-pushed the allow-specific-files-tsconfig branch from 0d9913b to 24b5726 Compare April 24, 2020 13:22
@ahnpnl ahnpnl merged commit 0904d12 into 25.x.x Apr 25, 2020
@ahnpnl ahnpnl deleted the allow-specific-files-tsconfig branch April 25, 2020 06:15
ahnpnl added a commit that referenced this pull request Apr 27, 2020
BREAKING CHANGE:

Any custom typing files or files which are needed to be compiled and intended to use with `jest` need to be defined in `files` option of `tsconfig`.

For example
```
// tsconfig.json
{
   // ...other configs
   "files": [
       "my-custom-typings.d.ts".
       "my-global-module.ts"
   ]
}
```
ahnpnl added a commit that referenced this pull request Apr 28, 2020
BREAKING CHANGE:

Any custom typing files or files which are needed to be compiled and intended to use with `jest` need to be defined in `files` option of `tsconfig`.

For example
```
// tsconfig.json
{
   // ...other configs
   "files": [
       "my-custom-typings.d.ts".
       "my-global-module.ts"
   ]
}
```
ahnpnl added a commit that referenced this pull request Apr 28, 2020
…g` (#1562)

BREAKING CHANGE:

Any custom typing files or files which are needed to be compiled and intended to use with `jest` need to be defined in `files` option of `tsconfig`.

For example
```
// tsconfig.json
{
   // ...other configs
   "files": [
       "my-custom-typings.d.ts".
       "my-global-module.ts"
   ]
}
```
ahnpnl added a commit that referenced this pull request Apr 29, 2020
…g` (#1562)

BREAKING CHANGE:

Any custom typing files or files which are needed to be compiled and intended to use with `jest` need to be defined in `files` option of `tsconfig`.

For example
```
// tsconfig.json
{
   // ...other configs
   "files": [
       "my-custom-typings.d.ts".
       "my-global-module.ts"
   ]
}
```
ahnpnl added a commit that referenced this pull request Apr 29, 2020
…g` (#1562)

BREAKING CHANGE:

Any custom typing files or files which are needed to be compiled and intended to use with `jest` need to be defined in `files` option of `tsconfig`.

For example
```
// tsconfig.json
{
   // ...other configs
   "files": [
       "my-custom-typings.d.ts".
       "my-global-module.ts"
   ]
}
```
ahnpnl added a commit that referenced this pull request Apr 30, 2020
…g` (#1562)

BREAKING CHANGE:

Any custom typing files or files which are needed to be compiled and intended to use with `jest` need to be defined in `files` option of `tsconfig`.

For example
```
// tsconfig.json
{
   // ...other configs
   "files": [
       "my-custom-typings.d.ts".
       "my-global-module.ts"
   ]
}
```
ahnpnl added a commit that referenced this pull request May 1, 2020
…g` (#1562)

BREAKING CHANGE:

Any custom typing files or files which are needed to be compiled and intended to use with `jest` need to be defined in `files` option of `tsconfig`.

For example
```
// tsconfig.json
{
   // ...other configs
   "files": [
       "my-custom-typings.d.ts".
       "my-global-module.ts"
   ]
}
```
ahnpnl added a commit that referenced this pull request May 1, 2020
…g` (#1562)

BREAKING CHANGE:

Any custom typing files or files which are needed to be compiled and intended to use with `jest` need to be defined in `files` option of `tsconfig`.

For example
```
// tsconfig.json
{
   // ...other configs
   "files": [
       "my-custom-typings.d.ts".
       "my-global-module.ts"
   ]
}
```
ahnpnl added a commit that referenced this pull request May 4, 2020
…g` (#1562)

BREAKING CHANGE:

Any custom typing files or files which are needed to be compiled and intended to use with `jest` need to be defined in `files` option of `tsconfig`.

For example
```
// tsconfig.json
{
   // ...other configs
   "files": [
       "my-custom-typings.d.ts".
       "my-global-module.ts"
   ]
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants