feat(openapi): add tool to generate openapi docs #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charly Molter <[email protected]>
lahabana
requested review from
Automaat and
bartsmykla
and removed request for
a team
Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
6 tasks
Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
Automaat
reviewed
Oct 9, 2023
| } | ||
| } | ||
|
|
||
| async function fileIsOpenApiSpec(path) { |
There was a problem hiding this comment.
i am not a js specialist, but does this function need to be async if you await it instantly?
There was a problem hiding this comment.
No actually in JS you need to declare a funciton as async as soon as you use await inside it. I guess @johncowen or @kleinfreund could explain in detail. My guess is that this indicates that in reality this function returns a promise.
There was a problem hiding this comment.
That’s the rule, yes: a function that uses await in its immediate scope needs to be marked with the async keyword. That’s the case here.
Automaat
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tool which is usable as a docker image can be used in our repos to generate openapi specs from multiple existing ones.
This tool will be used in: kumahq/kuma#7975