-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mads): add mutex when checking if reconcile is needed and reconciling #11578
Conversation
…ling Signed-off-by: Ilya Lobkov <[email protected]>
I am not sure about this, MADS works in a weird way since it is responding to http requests not relying entirely on watchdogs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is simple fix. The more complex fix is trickier because of these reconcilers running concurrently makes 0 sense. So this will work for now
In my opinion the watchdog runs in goroutine and we need every interval to generate the XDS. And each http request gets response from go-control-plane Although we got that first tick reconcile from #11105, but you can imagine that the request happens between the first and second tick to fetch xds configurations then it would not found something new. That's why there's a restCallback function in MADS. |
Signed-off-by: Ilya Lobkov <[email protected]>
…into fix/mads-flakes
This is a straightforward fix for the MADS problem we see in unit tests. But we probably don't need
NeedsReconciliation
at all since we fixed watchdogs to reconcile before the first tick #11105CC @Automaat @michaelbeaumont
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --ci/
labels to run additional/fewer testsUPGRADE.md
? --