Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): due to a bug in checkout action we need to use github.sha #7184

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Jul 6, 2023

Due to a bug in checkout action mentioned here actions/checkout#1359 and here actions/checkout#881 we need to explicitly set ref to have the proper SHA put in helm charts on pull requests builds.

Changelog: skip

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@slonka slonka added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Jul 6, 2023
@slonka slonka requested a review from a team as a code owner July 6, 2023 06:39
@slonka slonka requested review from bartsmykla and lobkovilya and removed request for a team July 6, 2023 06:39
@slonka slonka force-pushed the use-gh-sha-for-helm-release branch from a24cb59 to 9e7faed Compare July 6, 2023 06:46
@slonka slonka merged commit de9bba9 into kumahq:master Jul 6, 2023
@michaelbeaumont
Copy link
Contributor

I think this isn't necessarily a bug per se, we're checking out a different commit now, PR branch head vs a merge commit. I think it's what we want though and I think it matches CircleCI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants