Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart.js v4 compatibility #83

Merged
merged 2 commits into from
Nov 22, 2022
Merged

chart.js v4 compatibility #83

merged 2 commits into from
Nov 22, 2022

Conversation

stockiNail
Copy link
Contributor

@stockiNail stockiNail commented Nov 21, 2022

V4 compatible.

@kurkle I haven't changed the version of the controller, in package.json, I don't know which one you prefer to set. Let me know

@kurkle kurkle added this to the 0.12.0 milestone Nov 22, 2022
@kurkle kurkle added the bug Something isn't working label Nov 22, 2022
@kurkle
Copy link
Owner

kurkle commented Nov 22, 2022

V4 compatible.

@kurkle I haven't changed the version of the controller, in package.json, I don't know which one you prefer to set. Let me know

Make it 0.12.0, please

@stockiNail
Copy link
Contributor Author

V4 compatible.
@kurkle I haven't changed the version of the controller, in package.json, I don't know which one you prefer to set. Let me know

Make it 0.12.0, please

done

@sonarcloud
Copy link

sonarcloud bot commented Nov 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kurkle kurkle merged commit ef0e952 into kurkle:master Nov 22, 2022
@kurkle kurkle changed the title Make v4 compatible chart.js v4 compatibility Nov 22, 2022
@kurkle kurkle added enhancement New feature or request and removed bug Something isn't working labels Nov 22, 2022
@stockiNail stockiNail deleted the chartjsv4 branch November 24, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants