Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.8.1: Added the lint-staged configuration and maintenance updates #57

Merged
merged 12 commits into from
Nov 12, 2023

Conversation

kurone-kito
Copy link
Owner

Features

Bug fixes

  • 4f200fc: added the license type to manifests

Other updates

  • 3055e34: updated the dependencies
  • 88d5aed: updated and migrated the Yarn version to v4
  • 431aad5: improved the CI/CD scripts

@kurone-kito kurone-kito added bug Something isn't working enhancement New feature or request dependencies add, remove, or update the dependencies labels Nov 12, 2023
@kurone-kito kurone-kito self-assigned this Nov 12, 2023
@reviewpad reviewpad bot added large Pull request is large waiting-for-review and removed dependencies add, remove, or update the dependencies labels Nov 12, 2023
Copy link
Contributor

reviewpad bot commented Nov 12, 2023

Reviewpad Report

‼️ Errors

  • Unconventional commit detected: 'chore(root): updated and migrated the Yarn version to v4

Q: Why not migrate to npm v10?
A: In the past, during the npm v7 days, I experienced various problems in
hoisting up. I tried this during the Yarn v4 transition, but I still have
this on hold due to difficulties with parallel execution of npm-scripts in
the workspace.

see: npm/rfcs#610' (88d5aed)

  • Unconventional commit detected: '0.8.1' (72739e2)

Copy link
Contributor

reviewpad bot commented Nov 12, 2023

AI-Generated Summary: This pull request involves a large number of changes across various areas of the repository.

Significant updates to the .yarnrc.yml include additions of new configuration parameters, the removal of plugin configurations, and deletion of yarnPath. This, along with the deletion of the file .yarn/plugins/@yarnpkg/plugin-engines.cjs indicate a revised approach towards yarn usage within the project.

Several package.json files in packages such as cspell-config, TypeScript SDK, and prettier-config have been updated, predominantly involving version upgrades and additions of MIT licenses. The engine version for Yarn has also been updated to 4.0.1.

In terms of code quality and formatting, changes have been made to accommodate the use of ESLint and Prettier within a Yarn PnP environment, with new files added such as unsupported-api.js and prettier.cjs. Additionally, the configurations for lint-staging have been detailed in the newly created 'README.md'.

The GitHub action workflows have been updated to use newer action versions and more accurate descriptions. The .gitignore, .eslintignore, and tsconfig.json files also received modifications, mainly for improved file handling and stringent code formatting.

Move operations include the renaming of .yarn/sdks/prettier/index.js to .yarn/sdks/prettier/index.cjs and moving .lintstagedrc.yml to packages/lint-staged-config/lint-staged.config.yml.

Deletion operations include the constraints.pro file and .yarn/plugins/@yarnpkg/plugin-engines.cjs file, which may lead to modifications in dependent code and engine version enforcement respectively.

An important note is the creation of a new package named @kurone-kito/lint-staged-config with its own package.json and a README.md file for instructions on its setup and usage.

The changes to the .vscode/settings.json file and the switch from index.js to index.cjs in some places show a move towards CommonJS handling. Finally, updates to cspell.config.yml and .eslintignore suggest modifications in spell checking and linting ignore rules respectively.

@kurone-kito kurone-kito merged commit 9933326 into main Nov 12, 2023
11 checks passed
@kurone-kito kurone-kito deleted the add-the-lint-staged-configuration branch November 12, 2023 10:06
Copy link
Contributor

reviewpad bot commented Nov 12, 2023

📈 Pull Request Metrics

💻 Coding Time: 15 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request large Pull request is large waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant