Enable twofish as an optional dependency #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
As of now
pyjks
requires the install oftwofish
, even though according to the READMEtwofish
is only required to read UBER keystores.twofish
is a package that has no commits since 2013 and is not compatible with Python 3.3+. Installingtwofish
should be optional.Solution:
Enable
twofish
to be installed as anextras_require
.Testing:
I was able to build with Python 2 and Python 3 without issues, with and without
twofish
.tox
tests pass for all Python versions there are tests for.Notes:
setup.cfg
andrequirements.txt
that are not required to enabletwofish
to be installed optionally.