-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added grpcweb proxy that allows me to access grpc endpoints from the ui #39
Conversation
…m the ui on the same port
d5bbc89
to
776bc29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have asked some questions. pending concerns
- cmux hasn't had any updates since 2021 - is this still the right choice?
- some possible race conditions that I am worried about
- concerns about grpcweb not supporting a few of our features
- can I get a notion explaining this architecture. why we are making this choice? how will it be working underneath? how does cmux play with grpcweb? The next dev we onboard and the rest of the team can use this.
1.cmux for multiplexes seems like the best choice at least for serving requests on same port; this is not long term imo. I have seen it being used by other repos like opentracing etc.. so don't think it should be a huge issue.
3.grpcweb not supporting features like bi-di and client is fine for now; as in near term that is not needed and by then we should invest time on supporting connect.
|
Is it okay for the frontend to not support upload files / upload StarlarkPackage? |
yeah - i don;t think we are supporting that behaviour in short term for frontend. |
Using grpcWeb proxy to enable ui to access grpc endpoints; here is the https://github.com/improbable-eng/grpc-web
To expose both grpcWeb and grpc, I am using cmux here: https://github.com/soheilhy/cmux/tree/master
Changelog picked up from commits here:
feat: added grpcweb proxy that allows me to access grpc endpoints from the ui on the same port