Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last_error field isn't properly defined #96

Closed
excalq opened this issue Apr 20, 2023 · 0 comments · Fixed by #98
Closed

Last_error field isn't properly defined #96

excalq opened this issue Apr 20, 2023 · 0 comments · Fixed by #98

Comments

@excalq
Copy link
Contributor

excalq commented Apr 20, 2023

The PipelineReloadResponse.pipelines.reloads.last_error is defined in fetcher/responses/nodestats_response.go as a string, however it is an object with message and backtrace properties.

At runtime this produces a non-fatal warning once a pipeline failure is introduced:

executor nodestats failed after 41.930542ms: json: cannot unmarshal object into Go struct field PipelineReloadResponse.pipelines.reloads.last_error of type string
excalq added a commit to excalq/logstash-exporter that referenced this issue Apr 21, 2023
@excalq
Fixes kuskoman#96, Last_error field isn't properly defined
6292739
excalq added a commit to excalq/logstash-exporter that referenced this issue Apr 21, 2023
@excalq
Fixes kuskoman#96, Last_error field isn't properly defined
02afa2f
@excalq excalq mentioned this issue Apr 21, 2023
Merged
kuskoman pushed a commit to excalq/logstash-exporter that referenced this issue Apr 21, 2023
@excalq @kuskoman
Fixes kuskoman#96, Last_error field isn't properly defined
2472eb9
kuskoman added a commit that referenced this issue Apr 21, 2023
@excalq @kuskoman
Add reload timestamps to metrics (#99)
a4321ac 
* Use version sort add_metrics_to_readme.sh

* #93: Adds logstash_stats_pipeline_up metrics

* Add newline to EOF

* Adds reload timestamp metrics

* Fixes #96, Last_error field isn't properly defined

* Adds timestamp metrics to test/snapshot/readme

* Remove pipeline up metric

---------

Co-authored-by: Jakub Surdej <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix last_error field not being properly defined excalq/logstash-exporter
1 participant
@excalq