Fix nident error in configmap setting, improve Helm testing workflow #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #245 +/- ##
=======================================
Coverage 99.61% 99.61%
=======================================
Files 14 14
Lines 774 774
=======================================
Hits 771 771
Misses 2 2
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
thank you @MatthyB for finding it |
kuskoman
force-pushed
the
fix-232-once-again
branch
from
952f3a9
to
e9a15be
Compare
kuskoman
force-pushed
the
fix-232-once-again
branch
from
d126188
to
a4ee4a4
Compare
kuskoman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #232