Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code readability in pipelines subcollector #265

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

satk0
Copy link
Collaborator

@satk0 satk0 commented Feb 13, 2024

Closes #264

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (984c1ee) 99.61% compared to head (7a6686c) 94.52%.
Report is 14 commits behind head on master.

Files Patch % Lines
cmd/exporter/main.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
- Coverage   99.61%   94.52%   -5.09%     
==========================================
  Files          14       15       +1     
  Lines         774      621     -153     
==========================================
- Hits          771      587     -184     
- Misses          2       34      +32     
+ Partials        1        0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satk0 satk0 closed this Feb 13, 2024
@satk0 satk0 deleted the improve-readability branch February 13, 2024 14:05
@satk0 satk0 restored the improve-readability branch February 13, 2024 14:12
@satk0 satk0 reopened this Feb 13, 2024
@kuskoman kuskoman changed the title Improve code readability (closes #264) Improve code readability in pipelines subcollector Feb 13, 2024
@kuskoman kuskoman merged commit 433021b into kuskoman:master Feb 13, 2024
39 of 41 checks passed
@satk0 satk0 deleted the improve-readability branch February 16, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve code readability of pipelines subcollector
2 participants