Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add_metrics_to_readme.sh script #272

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

satk0
Copy link
Collaborator

@satk0 satk0 commented Feb 14, 2024

Link #266
Resolves #269

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (984c1ee) 99.61% compared to head (184fb0d) 94.52%.
Report is 16 commits behind head on master.

Files Patch % Lines
cmd/exporter/main.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
- Coverage   99.61%   94.52%   -5.09%     
==========================================
  Files          14       15       +1     
  Lines         774      621     -153     
==========================================
- Hits          771      587     -184     
- Misses          2       34      +32     
+ Partials        1        0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kuskoman kuskoman merged commit 6b5ca71 into kuskoman:master Feb 14, 2024
20 of 21 checks passed
@satk0 satk0 deleted the fix-add-metrics-script branch February 16, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor add_metrics_to_readme.sh, so that it passes linting
2 participants