Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create_release_notes.sh script #289

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

satk0
Copy link
Collaborator

@satk0 satk0 commented Feb 16, 2024

Link #266
Resolves #270

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (984c1ee) 99.61% compared to head (188b19c) 94.52%.
Report is 29 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
- Coverage   99.61%   94.52%   -5.09%     
==========================================
  Files          14       15       +1     
  Lines         774      621     -153     
==========================================
- Hits          771      587     -184     
- Misses          2       34      +32     
+ Partials        1        0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

echo "" >> "$notes_file"
echo "$commits_since_previous_tag" >> "$notes_file"
{
# new line
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this comment for?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dla beki. I will delete it.

@kuskoman kuskoman self-requested a review February 16, 2024 12:41
@kuskoman kuskoman merged commit daf7867 into kuskoman:master Feb 16, 2024
21 checks passed
@satk0 satk0 deleted the fix-create_release_notes branch March 2, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor create_release_notes.sh, so that it passes linting
2 participants