Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric for pipelines indicating if they are up #94

Merged
merged 7 commits into from
Apr 27, 2023

Conversation

excalq
Copy link
Contributor

@excalq excalq commented Apr 20, 2023

Resolves #93 by adding logstash_stats_pipeline_up{pipeline_id}, with a boolean gauge metric.

Uses sort --version-sort in scripts/add_metrics_to_readme.sh for correct mixed string/number sorting of README metrics.

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f7c7c13) 100.00% compared to head (9fb9120) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #94   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          480       496   +16     
=========================================
+ Hits           480       496   +16     
Impacted Files Coverage Δ
collectors/nodestats/pipeline_subcollector.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@excalq excalq force-pushed the excalq/93-boolean-piplines-up branch 2 times, most recently from 0ac4f87 to 3627bec Compare April 26, 2023 01:06
@excalq
Copy link
Contributor Author

excalq commented Apr 26, 2023

Other than the test coverage issue on the impossible-to-reach return statement, this should be ready to merge. It's rebased from master.

@kuskoman
Copy link
Owner

@excalq could you rebase this PR and update metric names after that (if required)?
Thanks in advance!

@kuskoman
Copy link
Owner

@excalq after merging this PR I will release next version as a tag

@excalq
Copy link
Contributor Author

excalq commented Apr 26, 2023

@kuskoman Cool, I see that #101 was merged. This changes NewDescWithHelpAndLabels(), hence the conflicts here. I'll rebase now.

@excalq excalq force-pushed the excalq/93-boolean-piplines-up branch from dcff8c1 to ea9b0b9 Compare April 26, 2023 17:56
@kuskoman kuskoman force-pushed the excalq/93-boolean-piplines-up branch from ea9b0b9 to 518ca46 Compare April 27, 2023 13:12
@kuskoman kuskoman force-pushed the excalq/93-boolean-piplines-up branch from 518ca46 to fb72979 Compare April 27, 2023 13:12
@kuskoman
Copy link
Owner

@excalq I allowed myself to do rebase, force-push and a little refactor, could you take a last look on the code before I merge it?

@excalq
Copy link
Contributor Author

excalq commented Apr 27, 2023

The show stopper is the duplicated last_timestamps metrics. I can fix that now.

@kuskoman kuskoman changed the title #93 boolean piplines up Add metric for pipelines indicating if they are up Apr 27, 2023
@kuskoman
Copy link
Owner

@excalq can I merge it after CI is passed? I will squash the commits therefore I changed the title to be a commit message

@excalq
Copy link
Contributor Author

excalq commented Apr 27, 2023

The duplication is fixed (might be a good future test, btw), so everything's ready to merge. None of my comments are blockers btw, so please resolve them.

@kuskoman kuskoman merged commit ded28c1 into kuskoman:master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Boolean Metric for Instantaneous Pipeline Health
2 participants