feat: warn on microsecond granularity and empty string summary #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBernstorff
force-pushed
the
warn_on_microsecond_granularity
branch
from
6d348c2
to
baf2887
Compare
kuzmoyev
reviewed
May 26, 2024
kuzmoyev
reviewed
May 26, 2024
MartinBernstorff
force-pushed
the
warn_on_microsecond_granularity
branch
from
52a64f0
to
c142a6f
Compare
MartinBernstorff
changed the title
MartinBernstorff
force-pushed
the
warn_on_microsecond_granularity
branch
2 times, most recently
from
468caa6
to
a47ff3f
Compare
MartinBernstorff
force-pushed
the
warn_on_microsecond_granularity
branch
from
4125ab0
to
37f7bb5
Compare
|
A few "line too long", I'll take a look. BTW, would you be open to adding a formatter (e.g. ruff/black?). Should make this easier 👍 |
Yeah, I'm a bit against black in general for some of its style decisions and lack of context awareness which often breaks readability. I see its benefits for bigger teams but this project doesn't have one. So I'd prefer readability here. But I agree that this workflow should be improved. I think we can use the flake8 pre-commit hook for that. |
|
LGTM. Thank you for the PR and finding the issues! Merging to dev until release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #189 and fixes #190.