Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: warn on microsecond granularity and empty string summary #191

Merged

Conversation

MartinBernstorff
Copy link
Contributor

@MartinBernstorff MartinBernstorff commented May 26, 2024

Fixes #189 and fixes #190.

@MartinBernstorff MartinBernstorff force-pushed the warn_on_microsecond_granularity branch from 6d348c2 to baf2887 Compare May 26, 2024 13:59
gcsa/event.py Outdated Show resolved Hide resolved
gcsa/event.py Outdated Show resolved Hide resolved
@kuzmoyev kuzmoyev changed the base branch from master to dev May 26, 2024 14:47
tests/test_event.py Outdated Show resolved Hide resolved
@MartinBernstorff MartinBernstorff force-pushed the warn_on_microsecond_granularity branch from 52a64f0 to c142a6f Compare May 26, 2024 14:59
@MartinBernstorff MartinBernstorff changed the title feat: warn on microsecon granularity and empty string summary feat: warn on microsecond granularity and empty string summary May 26, 2024
@MartinBernstorff MartinBernstorff force-pushed the warn_on_microsecond_granularity branch 2 times, most recently from 468caa6 to a47ff3f Compare May 26, 2024 15:25
@MartinBernstorff MartinBernstorff force-pushed the warn_on_microsecond_granularity branch from 4125ab0 to 37f7bb5 Compare May 26, 2024 15:26
Copy link
Contributor Author

@MartinBernstorff MartinBernstorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the feedback!

BTW, the code-base was pretty nice to dive into, kudos 👍

gcsa/event.py Outdated Show resolved Hide resolved
gcsa/event.py Outdated Show resolved Hide resolved
gcsa/event.py Outdated Show resolved Hide resolved
tests/test_event.py Outdated Show resolved Hide resolved
@MartinBernstorff
Copy link
Contributor Author

A few "line too long", I'll take a look.

BTW, would you be open to adding a formatter (e.g. ruff/black?). Should make this easier 👍

@kuzmoyev
Copy link
Owner

BTW, would you be open to adding a formatter (e.g. ruff/black?). Should make this easier 👍

Yeah, I'm a bit against black in general for some of its style decisions and lack of context awareness which often breaks readability. I see its benefits for bigger teams but this project doesn't have one. So I'd prefer readability here.

But I agree that this workflow should be improved. I think we can use the flake8 pre-commit hook for that.

@kuzmoyev kuzmoyev linked an issue May 26, 2024 that may be closed by this pull request
@kuzmoyev
Copy link
Owner

LGTM.

Thank you for the PR and finding the issues!

Merging to dev until release.

@kuzmoyev kuzmoyev merged commit c334a9d into kuzmoyev:dev May 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants