Allow typescript file to be used by sdk:execute #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmauNeko
requested changes
Dec 12, 2023
src/commands/sdk/execute.ts
Outdated
| @@ -69,33 +71,70 @@ Other | |||
|
|
|||
| static readStdin = true; | |||
|
|
|||
| async toJavascript(filename: string): Promise<boolean> { | |||
| return new Promise((resolve, reject) => { | |||
| exec( | |||
There was a problem hiding this comment.
It might be better to use the programmatic api in order to avoid relying on exec and to save up on temp file reading / writing.
https://github.com/microsoft/TypeScript/wiki/Using-the-Compiler-API#a-simple-transform-function
src/commands/sdk/execute.ts
Outdated
| async beforeConnect() { | ||
| this.code = this.stdin || this.args.code || "// paste your code here"; | ||
| try { | ||
| eval(this.code); |
There was a problem hiding this comment.
If possible, it would be preferable to attempt evaluating in a separate V8 context
https://nodejs.org/api/vm.html#vmruninnewcontextcode-contextobject-options
fmauNeko
approved these changes
Dec 13, 2023
This was referenced Dec 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the possibility to use typescript file with the method sdk:execute
How should this be manually tested?
...
Other changes
Boyscout