Include plugins in docker image #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvalev
force-pushed
the
kvv-docker-include-plugins
branch
2 times, most recently
from
bf3ba19
to
fe44633
Compare
Uffizzi Ephemeral Environment
|
|
Trying to help you with this PR. I tested it and unfortunately this incarnates a golang issue. Quick search pointed at: golang/go#51955 |
kvalev
force-pushed
the
kvv-docker-include-plugins
branch
4 times, most recently
from
01f9525
to
bf58330
Compare
kvalev
force-pushed
the
kvv-docker-include-plugins
branch
from
bf58330
to
c29c0f7
Compare
|
@rickysarraf Go is quite picky about those plugin builds - not only the code has to match, but also the build flags (used for the plugin and the binary). The latest version of this PR works and the plugin solibs are loaded correctly, but the build code is not pretty. I need to think of a way to integrate it nicely into the current build, without having to copy-paste it for everyone of the dozens of Also given Go's plugin pickiness, it's even worth considering integrating those few plugins natively into the codebase, instead of dynamically loading them at runtime. And if someone wants to develop their own plugin, at the end it might be easier to just include it in this repository, than having to recompile it with every new version. |
Thank you @kvalev I finally got it working with this current PR. Instead of copying the shared object files, I just symlinked the folder so that it is auto-updated. As for the plugins, they seem to be working. Though I'll wait for the final results to reflect in the WebUI, which is going to take time until the Right now, I have: But both YoLo and Realesgran plugins are working, as per the server-side logs: |
The |
Indeed, it can be quite memory hungry, especially if you feed it larger images. And to be honest, I was not very happy with the results that I got for my low resolution images, but given that I had already implemented it, I left it in the codebase. The yolo8 classification plugin is way more practical. |
|
About the objects detected by Yolo, how do those detections get fed to PP ? I couldn't find a strong debug statement there about populating the detected objects into PP. |
|
There also the case, where images generated by extraction of frame from a video, is not well understood by Yolo |
Okay! So it is the threshold the decides. |
Some more logs on this subject. I'm glad that it is able to extract an image and run classification on it. |
|
@kvalev Would be nice to have this merged as well. 🙏🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #130, #131
closes #137