Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commonLabels to be applied to all created resources #30

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

debbabi
Copy link
Contributor

@debbabi debbabi commented Dec 18, 2023

Application of commonLabels to all resources created by the chart.
The addition of commonLabels provides consistency and aids in better resource management by applying specific labels uniformly across all resources.

Changes Made:

  • Implemented support for commonLabels in the Helm chart.
  • Updated templates to include the commonLabels field for all resources generated by the chart.

Compatibility Considerations:

  • These changes do not impact existing deployments that do not specify commonLabels.
  • Users can opt to utilize commonLabels for their specific requirements without affecting the chart's backward compatibility.

@kvaps
Copy link
Owner

kvaps commented Dec 18, 2023

Hi, thanks for contribution, could you also bump a chart version?

@debbabi
Copy link
Contributor Author

debbabi commented Dec 18, 2023

Hey @kvaps
Thanks for your quick reaction.
I'm preparing a second PR to add "topologySpreadConstraints" config.
May I instead increase the version with this next PR?

@kvaps
Copy link
Owner

kvaps commented Dec 18, 2023

Yup, no problem

@kvaps kvaps merged commit b7f102e into kvaps:master Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants