(ISSUE-272) Allow to disable mod plugin in sync_triggers #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdealiLoKo
pushed a commit
to AbdealiLoKo/sqlalchemy-continuum
that referenced
this pull request
Aug 23, 2022
Pass sync_triggers kwargs through to create_triggers Allows use of native versioning without mod tracking
indiVar0508
pushed a commit
to indiVar0508/sqlalchemy-continuum
that referenced
this pull request
Sep 11, 2022
Pass sync_triggers kwargs through to create_triggers Allows use of native versioning without mod tracking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pg audit function was failing because it is built with
_modfeature enabled by default.There are a few ways to disable it, I had to copy/change sync_triggers, and I see other developers fork the repository. Neither of the solutions is good.
This PR allows passing create_triggers arguments as sync_triggers kwargs.
I don't see a good way to detect if the plugin is enabled in sync_triggers.