add #286: Add parent table in utils #308
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Table.__versioning_manager__ so we can keep track of the manager used for a table. Allow table in get_versioning_manager() Also add unittests for the function
indiVar0508
force-pushed
the
add_parent_table
branch
from
64564e2
to
f02362b
Compare
AbdealiLoKo
reviewed
Sep 14, 2022
sqlalchemy_continuum/utils.py
Outdated
| parent_table = next( | ||
| iter( | ||
| t | ||
| for t in versioning_manager.association_tables |
There was a problem hiding this comment.
Can we change association_tables -> association_tables_map ?
That way we can do a simple lookup here instead of versioning_manager.options['table_name'] % t.name == table.name
There was a problem hiding this comment.
Hi @AbdealiJK ,
added a lookup dict to capture association version_tables
indiVar0508
force-pushed
the
add_parent_table
branch
from
f02362b
to
08f8284
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added parent_table method as suggested by @AbdealiJK in #286 using #299 ,