Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make RUSTFLAGS configurable #585

Merged
merged 2 commits into from
Sep 24, 2024
Merged

make RUSTFLAGS configurable #585

merged 2 commits into from
Sep 24, 2024

Conversation

XorSum
Copy link
Contributor

@XorSum XorSum commented Sep 23, 2024 •
edited
Loading

Which issue does this PR close?

Closes #584

Rationale for this change

to use the default configuration

mvn package -P"${SHIM}" -P"${MODE}"

to use the specified configuration by setting the RUSTFLAGS env

RUSTFLAGS="-C target-feature=+aes,+sse2" mvn package -P"${SHIM}" -P"${MODE}"

What changes are included in this PR?

Are there any user-facing changes?

No

@XorSum XorSum changed the title build-native.sh RUSTFLAGS="-C target-feature=+aes,+sse2" make RUSTFLAGS configurable Sep 23, 2024
@richox richox merged commit a3073c9 into kwai:master Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richox richox richox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RUSTFLAGS='-C target-cpu=native' causes jvm crash when compile and runtime environments differ
2 participants
@XorSum @richox