-
Notifications
You must be signed in to change notification settings - Fork 57
Login on firefox fails #199
Comments
After some search, i noticed that for some reason the I am not sure why this happens in firefox specifically, but apparently sometimes the Modifying
to
seems to be solving the problem, because it caches the |
Hmm, that's strange that it works in Chrome but not FF, can you find any previous reference to the missing client id in the logs prior to the exception? Client states are dropped by the server after a timeout, but that should be 48 hours so I doubt it's the problem here. The client state should be created on initial page render here, so that it's present when the websocket connects. Is it possible the websocket is being broken? I think this change is relatively recent, it will drop the client state when the websocket is broken - whereas previously it relied on the timeout for this. It might make sense to go back to that approach. Do you see a |
@sanity indeed, as a matter of fact i tried reverting the recent change you mentioned back to dropping the client state after a timeout, and yes, it works with the old implementation. The problem, as you mentioned, seems to occur with this recent change.
No, but i see this |
Hmm, ok - I'm going to reduce the default timeout to 4 hours and remove that invalidation and release as 0.9.2 in a few minutes. The original purpose of that was to prevent RAM from filling up with these ClientStates, but I think a better solution might be to make the |
Ok, just released |
@sanity Unfortunately the problem still persists for firefox browser. It only works if i completely remove the |
Hmm, crap - ok, I think I understand the issue, will fix once I get back to my desktop and deploy a new version. Thank you. |
Just released |
@sanity I know i'm being annoying at this point, sorry for that, but the problem still persists. |
You're not being annoying at all, I appreciate the assistance with debugging, sorry it's taking so long. That's confusing though, line 321 should only be executed if the I'll disable it and release 0.9.5, and create a new issue to investigate. |
|
Yes, thanks, now i can login from firefox :D . |
Describe the bug
Hello,
I have a ktor based login page, with username and password, using POST method. It has been working fine for all kweb versions, until
0.8.9
. With0.9.0
and0.9.1
, it still works on chrome based browsers but fails on mozilla firefox with the following stacktrace:Expected behavior
The login should succeed, just like it does in chrome based browsers.
Edit: After checking past issues, this could potentially be related to
#191
. However, i don't have multiple instances to route traffic into, and session affinity is used anyway.The text was updated successfully, but these errors were encountered: