This repository has been archived by the owner on Aug 10, 2024. It is now read-only.
Fix CI/CD, and additional config updates #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting re: JDKs, I would have assumed more recent would be better. Why do you think 11 might be preferable? |
|
Basically because 11 is more widely supported, and because Kweb is Kotlin, it doesn't really matter what version of Java it's using - only what JDK level it's compatible with. |
|
@aSemy Feel free to merge to |
|
Okay, it looks like JitPack is working now https://jitpack.io/com/github/aSemy/kweb-core/feat~gha_updates-42308896e5-1/build.log |
|
Cool, thanks! btw, for JitPack have you set up the webhook? https://jitpack.io/docs/BUILDING/#building-ahead-of-time |
|
No, wasn't aware of that, I'll take a look. Thanks so much for all your help! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing JitPack and GHA
I think using JDK11 might be better than JDK17... but let's see how this goes.