feat(client): add auth logout method #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add kwil.auth.logout() method to remove cookie when using KGW.
Yaiba
requested changes
Apr 14, 2024
src/auth/auth.ts
Outdated
| } | ||
|
|
||
| /** | ||
| * Authenticates a user with the Kwil Gateway (KGW). This is required to execute mustsign view actions. |
There was a problem hiding this comment.
The comment is outdated, 'mustsign' action is no longer supported
src/core/auth.ts
Outdated
| version: string, | ||
| chainId: string, | ||
| ): void { | ||
| if (authParm.domain !== domain) { |
There was a problem hiding this comment.
I think this is problematic if run against older kgw version? Since old kgw version won't return those fields.
There was a problem hiding this comment.
That is a good point - how are you handling this with Kwil-cli? Maybe we update the version number? So if > version 1, then run the verifyAuthProperties?
There was a problem hiding this comment.
We didn't change 'version', since 'version' is for something like template.
https://github.com/kwilteam/kwil-db/pull/657/files#diff-2a7eaeea47cbb7c8cd1df3a3972976df3131d7634f9d6a1d26d2409ee064718cR165 I only compare if the field is returned from KGW
add checks for auth properties from server before signing auth msg Update kwil.test.ts update auth msg
KwilMachine
force-pushed
the
feat/auth-logout
branch
from
67da0b1
to
d285a79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add kwil.auth.logout() method to remove cookie when using KGW.