chore(merge): Merge pull request ReactiveX#1778 from blesh/better-err…

…or-messages

Better error messages

spec/helpers/testScheduler-ui.ts

@@ -104,12 +104,25 @@ module.exports = function(suite) {
       .replace(/\\n/g, '\n');
     }
 
+    function deleteErrorNotificationStack(marble) {
+      const { notification } = marble;
+      if (notification) {
+        const { kind, exception } = notification;
+        if (kind === 'E' && exception instanceof Error) {
+          notification.exception = { name: exception.name, message: exception.message };
+        }
+      }
+      return marble;
+    }
+
     /**
      * custom assertion formatter for expectObservable test
      */
 
     function observableMatcher(actual, expected) {
       if (Array.isArray(actual) && Array.isArray(expected)) {
+        actual = actual.map(deleteErrorNotificationStack);
+        expected = expected.map(deleteErrorNotificationStack);
         const passed = _.isEqual(actual, expected);
         if (passed) {
           return;

spec/util/UnsubscriptionError-spec.ts

@@ -20,9 +20,9 @@ describe('UnsubscriptionError', () => {
     } catch (err) {
       expect(err instanceof UnsubscriptionError).to.equal(true);
       expect(err.message).to.equal(`2 errors occurred during unsubscription:
-1) ${err1}
-2) ${err2}`);
+  1) ${err1}
+  2) ${err2}`);
       expect(err.name).to.equal('UnsubscriptionError');
     }
   });
-});
+});

src/util/ArgumentOutOfRangeError.ts

@@ -10,7 +10,9 @@
  */
 export class ArgumentOutOfRangeError extends Error {
   constructor() {
-    super('argument out of range');
-    this.name = 'ArgumentOutOfRangeError';
+    const err: any = super('argument out of range');
+    (<any> this).name = err.name = 'ArgumentOutOfRangeError';
+    (<any> this).stack = err.stack;
+    (<any> this).message = err.message;
   }
-}
+}

src/util/EmptyError.ts

@@ -10,7 +10,9 @@
  */
 export class EmptyError extends Error {
   constructor() {
-    super('no elements in sequence');
-    this.name = 'EmptyError';
+    const err: any = super('no elements in sequence');
+    (<any> this).name = err.name = 'EmptyError';
+    (<any> this).stack = err.stack;
+    (<any> this).message = err.message;
   }
-}
+}

src/util/ObjectUnsubscribedError.ts

@@ -9,7 +9,9 @@
  */
 export class ObjectUnsubscribedError extends Error {
   constructor() {
-    super('object unsubscribed');
-    this.name = 'ObjectUnsubscribedError';
+    const err: any = super('object unsubscribed');
+    (<any> this).name = err.name = 'ObjectUnsubscribedError';
+    (<any> this).stack = err.stack;
+    (<any> this).message = err.message;
   }
-}
+}

src/util/UnsubscriptionError.ts

@@ -5,8 +5,11 @@
 export class UnsubscriptionError extends Error {
   constructor(public errors: any[]) {
     super();
-    this.name = 'UnsubscriptionError';
-    this.message = errors ? `${errors.length} errors occurred during unsubscription:
-${errors.map((err, i) => `${i + 1}) ${err.toString()}`).join('\n')}` : '';
+    const err: any = Error.call(this, errors ?
+      `${errors.length} errors occurred during unsubscription:
+  ${errors.map((err, i) => `${i + 1}) ${err.toString()}`).join('\n  ')}` : '');
+    (<any> this).name = err.name = 'UnsubscriptionError';
+    (<any> this).stack = err.stack;
+    (<any> this).message = err.message;
   }
-}
+}