Tested HW support for 72-2540, add pytest tests #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-phillips-nz
force-pushed
the
master
branch
from
9850ead
to
67a9904
Compare
|
HI @thomas-phillips-nz , everything looks good and clean. Thanks for your effort :-) I would suggest adding some small documentation at least in the README to explain about the tests and the two environment variables governing them before we merge this PR. |
|
Sure, will do when I get into the office tomorrow. Should I add pytest to requirements.txt? It's not really required for running, only development/testing. |
|
For the moment I think we do not need to add We could add it as |
thomas-phillips-nz
force-pushed
the
master
branch
from
67a9904
to
c2c255c
Compare
|
Have added changes to the readme now, and improved the test a little bit around finding the COM port. |
|
Looks good and clean, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to split everything into separate commits, can remove individual commits if you don't want to include them (e.g. removing trailing whitespace)
Tested everything in the new pytest file