Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly add packaging as a dependency #101

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Correctly add packaging as a dependency #101

merged 2 commits into from
Apr 18, 2024

Conversation

skasai5296
Copy link
Contributor

@skasai5296 skasai5296 commented Apr 17, 2024

This is a follow-up for facebookresearch/faiss#3191.

Issue

Importing faiss fails at runtime;

>>> import faiss
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File ".../site-packages/faiss/__init__.py", line 16, in <module>
    from .loader import *
  File ".../site-packages/faiss/loader.py", line 6, in <module>
    from packaging.version import Version
ModuleNotFoundError: No module named 'packaging'

@skasai5296 skasai5296 marked this pull request as ready for review April 17, 2024 06:08
@skasai5296 skasai5296 changed the title Add packaging to install_requires for setup Correctly add packaging as a dependency Apr 17, 2024
@kyamagu kyamagu self-requested a review April 17, 2024 08:45
Copy link
Owner

@kyamagu kyamagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyamagu kyamagu merged commit 7fe6682 into kyamagu:main Apr 18, 2024
7 checks passed
@skasai5296 skasai5296 deleted the skasai/add-packaging-install-requires branch April 18, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants