Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api._popperElement is undefined #105

Closed
urbany opened this issue Jun 12, 2019 · 0 comments · Fixed by #106
Closed

api._popperElement is undefined #105

urbany opened this issue Jun 12, 2019 · 0 comments · Fixed by #106
Labels

Comments

@urbany
Copy link
Contributor

urbany commented Jun 12, 2019

Hi, seems like there is a problem with the latest 0.10.0 release.

On my app, I always get that api._popperElement is undefined. I think this is because the API tries to get the _popperElement computed property before it returns.

  1. the REF modifier sets the computed prop _popperElement in ember-popper-base.
  2. Before that set returns, _updatePopperis called
  3. at the end of _updatePopper, registerAPI is called with _getPublicAPI
  4. Inside _getPublicAPI you are calling _getPopperElement which returns _popperElement.
  5. Since the SET of _popperElement (point 1 abose) hasn't returned yet, it is still null.

Screenshot 2019-06-12 at 12 12 15

Tested on [email protected] or even @3.9.

urbany added a commit to urbany/ember-popper that referenced this issue Jun 12, 2019
@simonihmig simonihmig added the bug label Jun 12, 2019
urbany added a commit to urbany/ember-popper that referenced this issue Jun 12, 2019
simonihmig added a commit that referenced this issue Jun 24, 2019
Pass correct popper element in the registerAPI #105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants