Popper v2 support #150
Open
Popper v2 support #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok. Nice. I'll look this over and if all is good we can have a breaking change. Thanks for this work. |
pzubar
commented
Jul 28, 2022
| */ | ||
| onUpdate: null, |
There was a problem hiding this comment.
onUpdate callback is gone https://popper.js.org/docs/v2/migration-guide/#9-update-callbacks
pzubar
commented
Jul 28, 2022
| @@ -42,11 +42,7 @@ | |||
| border-color: #FFC107; | |||
| } | |||
|
|
|||
| .popper[x-placement^="top"] { | |||
| margin-bottom: 5px; | |||
There was a problem hiding this comment.
The padding between the popper and its reference element is now managed with offset modifier https://popper.js.org/docs/v2/migration-guide/#4-remove-all-css-margins
pzubar
commented
Jul 28, 2022
| } | ||
|
|
||
| this._popper = new Popper(popperTarget, this._popperElement, options); | ||
| this._popper = Popper.createPopper(popperTarget, this._popperElement, options); |
There was a problem hiding this comment.
I am a bit newbie here so I am interested why can't we import popper like import { createPopper } from '@popperjs/core'; and have to use the UMD way? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issue.
It updates the addon's code to support popper v2 instead of popper.js. The migration is made according to the official migration guide.
The migration is the breaking change made in order to support the latest Poper's API. The components' API is changed accordingly.
Some of the changes that are not covered in a migration guide:
scheduleUpdate()is nowupdate()(and returns a promise). That means we can use it directly without wrapping the update with the "ember-raf-scheduler".