Fix broken build for consuming apps on ember-cli 2.10-2.13 when in test or prod mode #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en in test/prod mode
kybishop
changed the title
kybishop
force-pushed
the
allow-addon-to-be-used-in-consuming-app-tests
branch
from
16e85a2
to
5008041
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Absolute paths are needed for dev-only imports because of the way we strip them in prod/test mode. This caused prod and test builds to fail in consuming apps using ember-cli 2.10 to 2.13.
#shame#sorry. I believe 2.14 is still working because of fancy new dead-code elimination, which strips the import for us.In addition,
this.optionsin ember-popper's index.js is, for reasons not known to me,undefinedwhen the consuming app is running tests with ember 2.10 (and possibly other versions of ember before 2.13).These bugs are tricky to test because the dummy app and addon tests both work just fine regardless of either 🤔